Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best effort attempt to upgrade publish docker service to 1es deployment job #24023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seanimam
Copy link
Contributor

Description

1es pipelines have warnings requiring that all deployment jobs transition to release jobs (see Custom Release Job | 1ES On EngHub).

The docker publish pipeline is only run on new releases and is currently not working as expected (Even without these changes).

Given the infrequency of the pipeline running and its existing problems, this PR is a best effort attempt to convert it to a 1ES release job. The changes are simple and straightforward. This pipeline does not seem to violate any of the rules required of a 1ES release job and thus is does not require any modifications.

Reviewer Guidance

1ES Release Job Requirements: (see links above for more details)

  • You have to classify the release job as production or non-production based on whether you deploy to a production or non-production environment (in the case of deploying to Azure, this must match the Azure subscription classification in Service Tree).
  • You have to declare all the artifacts required for the release as inputs for the job (this is similar to the concept of outputs in a standard build job).
  • You can't build source code in a release job (this is to ensure all artifacts have been binary scanned in a build job output).
  • You can't check out repositories. All artifacts must be generated and published from a 1ES PT build job and declared as an input.
  • All 1ES PT pipelines must use a 1ES hosted pool.

@seanimam seanimam requested review from Copilot, tylerbutler and alexvy86 and removed request for Copilot and tylerbutler March 11, 2025 16:13
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Mar 11, 2025
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs rephrasing but otherwise lgtm!

# The `type: releaseJob` value makes this deployment job 1ES compliant.
# see https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/releasepipelines/releaseworkflows/releasejob?tabs=combined-pipeline for more info.
type: releaseJob
# This stage is only run in a production setting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This stage is only run in a production setting.
# This template is only referenced when publishing docker images to the public container registry, so it's always "production"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants