Added warning logging for retries #24031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the logging behavior for request retries by logging them as warnings until a retry limit is reached or when retries run indefinitely, according to the provided retry count and max retry configurations.
- Updated runWithRetry to log warnings if the retry count is below the maximum.
- Updated requestWithRetry with a similar change to use warning logs under the same conditions.
jfmendez11
approved these changes
Mar 11, 2025
server/routerlicious/packages/services-core/src/runWithRetry.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/services-core/src/runWithRetry.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/services-core/src/runWithRetry.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/services-core/src/runWithRetry.ts
Outdated
Show resolved
Hide resolved
znewton
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logging request retries as warnings instead of errors till the retryCount >= maxRetryCount or the maxRetryCount == -1 (Runs indefinitely).