fix file rename bug (#110)

microsoft · Nov 2, 2022 · 6e0987e · 6e0987e
1 parent 4d02026
commit 6e0987e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/common/src/main/java/com/microsoft/hydralab/common/util/AttachmentService.java b/common/src/main/java/com/microsoft/hydralab/common/util/AttachmentService.java
@@ -264,10 +264,10 @@ public File verifyAndSaveFile(@NotNull MultipartFile originFile, String parentDi
         }
 
         if (StringUtils.isEmpty(newFileName)) {
-            newFileName = FileUtil.getLegalFileName(newFileName);
             newFileName = filename.replace(fileSuffix, "") + "_" + System.currentTimeMillis() % 10000 + "_" + fileSuffix;
         }
 
+        newFileName = FileUtil.getLegalFileName(newFileName);
         File file = new File(parentDir, newFileName);// CodeQL [java/path-injection] False Positive: Has verified the string by regular expression
         InputStream inputStream = originFile.getInputStream();
         if (isBase64) {