Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azlinux3 dnf packages for compiler installation #423

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

saibulusu
Copy link
Contributor

For Azlinux3, we cannot use the dnf packages gcc-toolset and gcc-toolset-10-gcc-gfortran. Installing other packages via dnf.
Tested manually on an azlinux3 VM using:

  • PERF-MEM-LMBENCH.json
  • PERF-COMPRESSION-LZBENCH.json
  • PERF-CPU-LAPACK.json

@saibulusu saibulusu changed the title Users/saibulusu/azlinux3 fixes azlinux3 dnf packages for compiler installation Jan 16, 2025
@saibulusu saibulusu marked this pull request as ready for review January 16, 2025 22:17
@yangpanMS
Copy link
Contributor

If we do this, are we still checking if "CompilerVersion" matches what actually got installed?. Otherwise user might want gcc14 but got gcc11 instead.

@yangpanMS
Copy link
Contributor

On AzLinux since you can;t specify, user need to either overwrite the compilerVersion to "", or provide a version that matches the version installed

@yangpanMS
Copy link
Contributor

Actually, let's do this on all other distro as well. Default compiler version to string.empty, and if that happens, install version-less gcc/gfortran etc. If they specify a version, you install gcc-10 etc. On AzLinux, we throw error if user tries to pass in a version

@saibulusu
Copy link
Contributor Author

Actually, let's do this on all other distro as well. Default compiler version to string.empty, and if that happens, install version-less gcc/gfortran etc. If they specify a version, you install gcc-10 etc. On AzLinux, we throw error if user tries to pass in a version

How should we handle SetGccPriorityAsync when the user does not supply a version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants