Add conditional -k switch to CPS client command line #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Jan 22, 2025
| @@ -41,7 +41,7 @@ protected override string GetCommandLineArguments() | |||
| string clientIPAddress = this.GetLayoutClientInstances(ClientRole.Client).First().IPAddress; | |||
| string serverIPAddress = this.GetLayoutClientInstances(ClientRole.Server).First().IPAddress; | |||
|
|
|||
| return $"-c -r {this.Connections} " + | |||
| return $"-c -r {this.Connections} " + $"{((this.DataTransferMode == 2) ? "-k " : string.Empty)}" + | |||
There was a problem hiding this comment.
You will want to add unit test for this case
brdeyo
requested changes
Jan 22, 2025
This switch is required to insert 2 seconds delay between send/receive when the data transfer mode is set to 2, which is continuous send/receive.
Lekshmi-Ra
force-pushed
the
users/lekshmi-ra/cps
branch
from
aacfa5f to
e4a8369
Compare
|
Abandoning this PR as we're working on another approach which adds more flexibility to the execution of the tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switch is required to insert 2 seconds delay between send/receive when the data transfer mode is set to 2, which is continuous send/receive.