This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
increase viewport width from 600 to 1024px #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismohr
requested review from
cainhimself,
dan5382,
richardtagger,
swese44,
unindented and
vanschyndel
as code owners
|
Here's an example diff: |
chrismohr
force-pushed
the
increase_viewport_width
branch
from
14e960d
to
88f3b45
Compare
|
looks like you had a bad merge and reverted some previous code changes |
chrismohr
force-pushed
the
increase_viewport_width
branch
from
035e4f4
to
27453f8
Compare
chrismohr
commented
Jun 26, 2018
| @@ -441,7 +441,7 @@ | |||
| }, | |||
| "app-path": { | |||
| "version": "2.2.0", | |||
| "resolved": "https://onedrive.pkgs.visualstudio.com/_packaging/odsp-npm/npm/registry/app-path/-/app-path-2.2.0.tgz", | |||
There was a problem hiding this comment.
Fixed paths here.
chrismohr
commented
Jun 26, 2018
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Basic usage: | |||
|
|
|||
| ```js { "props": { "data-description": "basic" } } | |||
| ```js { "props": { "data-description": "basic", "data-action-states": "[{\"action\":\"none\",\"wait\":\"50\"}]" } } | |||
There was a problem hiding this comment.
Added wait to allow faster browser execution. (slowMo reduce from 40 to 10ms)
chrismohr
commented
Jun 26, 2018
| @@ -2,15 +2,15 @@ | |||
|
|
|||
| Basic usage: | |||
|
|
|||
| ```js { "props": { "data-description": "basic" } } | |||
| ```js { "props": { "data-description": "basic", "data-action-states": "[{\"action\":\"none\",\"wait\":\"100\"}]" } } | |||
There was a problem hiding this comment.
Added wait to allow faster browser execution. (slowMo reduce from 40 to 10ms)
unindented
reviewed
Jun 26, 2018
| @@ -7,6 +7,7 @@ module.exports = Object.assign({}, config, { | |||
| require: config.require.concat([path.resolve(__dirname, 'assets/disable-animations.css')]), | |||
| propsParser: () => ({}), // Faster without parsing props. They're not needed for diffs. | |||
| theme: { | |||
| maxWidth: 632, | |||
There was a problem hiding this comment.
It constrains the width of the styleguide, so that our screenshots stay the same width.
unindented
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to test the interactive states of the dropdown component. Currently the
The open state is rendering as side panel rather than a callout, because the viewport we set for puppeteer is so narrow that it triggers "responsive mode".
This also allows us to better test direction hints on callouts, which were currently rendering in the center because of the viewports size.
The reference images are able to stay the same width, because I hardcoded a max-width on the style guide to match the current width.
Unfortunately, a side effect of the viewport width change is that there are some virtually undetectable changes to pixels that will require us to update about 90 of the reference images. It seems mostly related to rounded corners, shadows and Illustrations.
One image actually changed, because the direction hint is now being accepted.
config/styleguide-visual/reference/Hovercard_alignments_hover_desktop.pngAdditionally, I've included a fix for #375, by adding a
waitto the specific example. Fixing this, allows us to reduceslowMofrom 40 to 10.This also revealed a MenuButton bug, filed here:
#421