-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic kernel model adapter #4851
Semantic kernel model adapter #4851
Conversation
I can see it is going to be useful for integrating with non-openai APIs such as Gemini and Mistral, using SK's large ecosystem of connectors. Could you show a few examples of such in the API documentation? This way users can take away a clear picture of why this model adapter is useful. |
f77cd39
to
3fe641e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
==========================================
+ Coverage 69.95% 70.15% +0.20%
==========================================
Files 168 172 +4
Lines 10716 10910 +194
==========================================
+ Hits 7496 7654 +158
- Misses 3220 3256 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
python/packages/autogen-ext/tests/models/test_sk_chat_completion_adapter.py
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/tools/semantic_kernel/_kernel_function_from_tool.py
Show resolved
Hide resolved
...n/packages/autogen-ext/src/autogen_ext/models/semantic_kernel/_sk_chat_completion_adapter.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If you have a chance could you just add the relevant tool and model pages here so that the API reference docs show up https://github.com/microsoft/autogen/tree/main/python/packages/autogen-core/docs/src/reference/python
We can always do it post merge if you'd rather just get this in to avoid conficts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc headings underlines need to be the same length as the title 😁
@jackgerrits @ekzhu , I added Let me know if you see any issues and I can revert it later. |
Why are these changes needed?
Related issue number
Checks