Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-problem-detector sources and remove unnecessary patches #12732

Open
wants to merge 2 commits into
base: fasttrack/3.0
Choose a base branch
from

Conversation

sameluch
Copy link
Contributor

@sameluch sameluch commented Mar 3, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fasttrack/3.0 is currently blocked by having unpopulated/unreconciled sources. PR to fix the issue directly following #12671

Change Log
  • Update tarball hashes for vendor tarballs
  • remove unnecessary patches
Does this affect the toolchain?

NO

Test Methodology
  • PR check
  • Local build
  • sudo make build-packages REBUILD_TOOLS=y SRPM_PACK_LIST=node-problem-detector PACKAGE_REBUILD_LIST=node-problem-detector DAILY_BUILD_ID=lkg RUN_CHECK=y -j100
    image

@sameluch sameluch requested a review from a team as a code owner March 3, 2025 19:46
@sameluch sameluch changed the title Sammeluch/fix node problem detector Fix node-problem-detector sources and remove unnecessary patches Mar 3, 2025
@Kanishk-Bansal
Copy link
Contributor

The PR #12727 covers this fix and also adds two new patches for High CVEs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants