feat(react-theme): semi-transparent support #31151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 628 | 614 | 5000 | |
| Button | mount | 292 | 315 | 5000 | |
| Field | mount | 1103 | 1106 | 5000 | |
| FluentProvider | mount | 719 | 699 | 5000 | |
| FluentProviderWithTheme | mount | 68 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 68 | 10 | |
| MakeStyles | mount | 891 | 866 | 50000 | |
| Persona | mount | 1758 | 1731 | 5000 | |
| SpinButton | mount | 1370 | 1344 | 5000 | |
| SwatchPicker | mount | 1573 | 1529 | 5000 |
bsunderhus
force-pushed
the
react-theme/feat--semi-transparent-support
branch
from
cf5d278 to
67f9d90
Compare
fabricteam
reviewed
May 14, 2024
| @@ -10,6 +10,7 @@ import type { | |||
| ComboboxBaseState, | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Accordion 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Size - RTL.normal.chromium.png | 2 | Changed |
| Accordion.Size.normal.chromium.png | 2 | Changed |
| Accordion.Size - Dark Mode.normal.chromium.png | 2 | Changed |
Avatar 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Active.normal.chromium.png | 5 | Changed |
| Avatar.Color.normal.chromium.png | 1 | Changed |
| Avatar.Color - RTL.normal.chromium.png | 1 | Changed |
| Avatar.Active Appearance.normal.chromium.png | 10 | Changed |
| Avatar.Active Appearance - Dark Mode.normal.chromium.png | 2 | Changed |
Badge 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge.Default.normal.chromium.png | 1 | Changed |
| Badge.Size.normal.chromium.png | 6 | Changed |
| Badge.Appearance.normal.chromium.png | 1 | Changed |
| Badge.Appearance - Dark Mode.normal.chromium.png | 15 | Changed |
| Badge.Shape.normal.chromium.png | 1 | Changed |
| Badge.Color.normal.chromium.png | 1 | Changed |
Button 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Button.Large Icon Only - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large Icon Only.hover.chromium.png | 4 | Changed |
| Button.Large Icon Only.default.chromium.png | 5 | Changed |
| Button.Large Icon Only - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon - RTL.pressed.chromium.png | 3 | Changed |
| Button.Large With Icon - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large Icon Only.pressed.chromium.png | 3 | Changed |
| Button.Large With Icon - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon - RTL.default.chromium.png | 5 | Changed |
| Button.Large With Icon.default.chromium.png | 5 | Changed |
| Button.Large Icon Only - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon - RTL.hover.chromium.png | 4 | Changed |
| Button.Large With Icon.hover.chromium.png | 4 | Changed |
| Button.Large With Icon - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon.pressed.chromium.png | 3 | Changed |
Divider 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider.With Svg - RTL.normal.chromium.png | 3 | Changed |
| Divider.With Svg.normal.chromium.png | 3 | Changed |
| Divider.Vertical With Svg.normal.chromium.png | 4 | Changed |
MenuList 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png | 5 | Changed |
| MenuList.Radio With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.2nd selected.chromium.png | 5 | Changed |
| MenuList.Checkbox With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.2nd selected.chromium.png | 4 | Changed |
| MenuList.Checkbox - RTL.2nd selected.chromium.png | 1 | Changed |
| MenuList.With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.2nd selected.chromium.png | 4 | Changed |
| MenuList.With Icons.hover menuitem.chromium.png | 3 | Changed |
Slider 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Slider.Size Small.rightArrow.chromium.png | 1 | Changed |
| Slider.Size Small.normal.chromium.png | 1 | Changed |
Switch 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Checked.hover.chromium.png | 1 | Changed |
| Switch.Checked - RTL.hover.chromium.png | 1 | Changed |
Text 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Block.normal.chromium.png | 995 | Changed |
TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput.Size Large.normal.chromium.png | 2 | Changed |
bsunderhus
force-pushed
the
react-theme/feat--semi-transparent-support
branch
3 times, most recently
from
3249bc9 to
6d123d6
Compare
bsunderhus
force-pushed
the
react-theme/feat--semi-transparent-support
branch
from
6d123d6 to
b5c8409
Compare
github-actions
bot
modified the milestones:
April Project Cycle Q1 2024,
July Project Cycle Q3 2024
🕵 fluentuiv9 No visual regressions between this PR and main |
fabricteam
reviewed
Jul 11, 2024
| @@ -17,6 +17,7 @@ import { EventHandler } from '@fluentui/react-utilities'; | |||
| import type { ExtractSlotProps } from '@fluentui/react-utilities'; | |||
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots
Pivot - Overflow 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png | 0 | Added |
| Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png | 0 | Added |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 620 | 613 | 5000 | |
| Breadcrumb | mount | 1720 | 1675 | 1000 | |
| Checkbox | mount | 1702 | 1697 | 5000 | |
| CheckboxBase | mount | 1469 | 1495 | 5000 | |
| ChoiceGroup | mount | 2909 | 2957 | 5000 | |
| ComboBox | mount | 689 | 672 | 1000 | |
| CommandBar | mount | 6555 | 6584 | 1000 | |
| ContextualMenu | mount | 13376 | 13616 | 1000 | |
| DefaultButton | mount | 805 | 795 | 5000 | |
| DetailsRow | mount | 2203 | 2224 | 5000 | |
| DetailsRowFast | mount | 2205 | 2267 | 5000 | |
| DetailsRowNoStyles | mount | 2078 | 2090 | 5000 | |
| Dialog | mount | 2807 | 2708 | 1000 | |
| DocumentCardTitle | mount | 243 | 222 | 1000 | |
| Dropdown | mount | 2045 | 1999 | 5000 | |
| FocusTrapZone | mount | 1163 | 1156 | 5000 | |
| FocusZone | mount | 1085 | 1079 | 5000 | |
| GroupedList | mount | 37931 | 42334 | 2 | |
| GroupedList | virtual-rerender | 20345 | 20334 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51177 | 51486 | 2 | |
| GroupedListV2 | mount | 224 | 240 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 210 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 222 | 2 | |
| IconButton | mount | 1122 | 1154 | 5000 | |
| Label | mount | 350 | 345 | 5000 | |
| Layer | mount | 2758 | 2749 | 5000 | |
| Link | mount | 405 | 394 | 5000 | |
| MenuButton | mount | 978 | 980 | 5000 | |
| MessageBar | mount | 21394 | 21405 | 5000 | |
| Nav | mount | 2055 | 2088 | 1000 | |
| OverflowSet | mount | 814 | 777 | 5000 | |
| Panel | mount | 1811 | 1803 | 1000 | |
| Persona | mount | 737 | 736 | 1000 | |
| Pivot | mount | 890 | 903 | 1000 | |
| PrimaryButton | mount | 934 | 935 | 5000 | |
| Rating | mount | 4676 | 4634 | 5000 | |
| SearchBox | mount | 937 | 911 | 5000 | |
| Shimmer | mount | 1877 | 1931 | 5000 | |
| Slider | mount | 1313 | 1342 | 5000 | |
| SpinButton | mount | 2949 | 2959 | 5000 | |
| Spinner | mount | 384 | 411 | 5000 | |
| SplitButton | mount | 1855 | 1873 | 5000 | |
| Stack | mount | 418 | 434 | 5000 | |
| StackWithIntrinsicChildren | mount | 906 | 918 | 5000 | |
| StackWithTextChildren | mount | 2791 | 2789 | 5000 | |
| SwatchColorPicker | mount | 6378 | 6444 | 5000 | |
| TagPicker | mount | 1469 | 1489 | 5000 | |
| Text | mount | 380 | 378 | 5000 | |
| TextField | mount | 954 | 966 | 5000 | |
| ThemeProvider | mount | 847 | 849 | 5000 | |
| ThemeProvider | virtual-rerender | 588 | 576 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1293 | 1316 | 5000 | |
| Toggle | mount | 598 | 616 | 5000 | |
| buttonNative | mount | 188 | 189 | 5000 |
|
Closing for housekeeping 🏡 Feel free to re-open |
|
reopening, although this won't be merged anytime soon, we need the verifications here for now |
github-actions
bot
modified the milestones:
July Project Cycle Q3 2024,
August Project Cycle Q3 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)