fix(react-charting): resolve bugs in declarative chart #33564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 7, 2025
change/@fluentui-react-charting-b50824ac-5ec3-43fe-af53-76307680fb75.json
Show resolved
Hide resolved
AtishayMsft
previously approved these changes
Jan 7, 2025
…c-svg-to-img-3
krkshitij
changed the base branch from
master
to
user/atisjai/stronglyTypePlotly
AtishayMsft
reviewed
Jan 16, 2025
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 16, 2025
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Outdated
Show resolved
Hide resolved
I think better way is to derive a type that we support like 'bar+line' or 'bar+line+scatter' and use it in the switch case. The jsx can be consts like renderChartJsx to be reusable across cases? Refers to: packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx:214 in 7607280. [](commit_id = 7607280, deletion_comment = False) |
AtishayMsft
reviewed
Jan 16, 2025
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Show resolved
Hide resolved
AtishayMsft
approved these changes
Jan 17, 2025
krkshitij
merged commit 03455a4
into
microsoft:user/atisjai/stronglyTypePlotly
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
Previous Behavior
New Behavior
Related Issue(s)