Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(react-tree): TreeRootReset component #33663

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feature(react-tree): TreeRootReset component #33663

merged 4 commits into from
Jan 16, 2025

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jan 15, 2025 •
edited
Loading

Previous Behavior

New Behavior

  1. aadd new component TreeRootReset, a contextual component that resets internal Tree logic that decides if a subtree if part of another parent tree or not

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus requested a review from a team as a code owner January 15, 2025 16:31
@bsunderhus bsunderhus self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.164 MB
291.345 kB		 1.164 MB
291.433 kB		 239 B
88 B
react-tree
FlatTree		 145.408 kB
41.829 kB		 145.565 kB
41.884 kB		 157 B
55 B
react-tree
PersonaFlatTree		 146.096 kB
41.931 kB		 146.251 kB
41.984 kB		 155 B
53 B
react-tree
PersonaTree		 142.318 kB
40.759 kB		 142.475 kB
40.818 kB		 157 B
59 B
react-tree
Tree		 141.63 kB
40.652 kB		 141.787 kB
40.712 kB		 157 B
60 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 69.236 kB
20.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 222.641 kB
64.474 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-timepicker-compat
TimePicker		 108.551 kB
36.094 kB
🤖 This report was generated against 9331bcc59d84d033784c73eab870155a02286ce5

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@bsunderhus bsunderhus marked this pull request as draft January 15, 2025 20:25
@bsunderhus bsunderhus force-pushed the react-tree/feature--Tree-root-override-property branch from 8c21c40 to ae648b8 Compare January 16, 2025 12:39
@bsunderhus bsunderhus changed the title feature(react-tree): Tree root override property feature(react-tree): TreeRootReset component Jan 16, 2025
@bsunderhus bsunderhus marked this pull request as ready for review January 16, 2025 12:40
@bsunderhus bsunderhus requested a review from a team as a code owner January 16, 2025 12:40
@bsunderhus bsunderhus requested a review from a team as a code owner January 16, 2025 14:58
Hotell
Hotell reviewed Jan 16, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
@bsunderhus bsunderhus requested review from Hotell and removed request for Hotell January 16, 2025 18:11
@bsunderhus bsunderhus merged commit 620ea3f into microsoft:master Jan 16, 2025
16 checks passed
@bsunderhus bsunderhus deleted the react-tree/feature--Tree-root-override-property branch January 16, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@Hotell Hotell Hotell left review comments

@ling1726 ling1726 ling1726 approved these changes

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
January Project Cycle Q1 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@bsunderhus @Hotell @fabricteam @ling1726