some more logging

microsoft · Feb 7, 2025 · 81508ae · 81508ae
1 parent 28d22dc
commit 81508ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.../cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSnapshotIterator.cs b/.../cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSnapshotIterator.cs
@@ -22,6 +22,8 @@ internal sealed unsafe class SnapshotIteratorManager
         readonly ReplicaSyncSession[] sessions;
         readonly int numSessions;
 
+        bool firstRead = false;
+
         public long CheckpointCoveredAddress { get; private set; }
 
         public SnapshotIteratorManager(ReplicationSyncManager replicationSyncManager, CancellationToken cancellationToken, ILogger logger = null)
@@ -79,6 +81,11 @@ void WaitForFlushAll()
 
         public bool Reader(ref SpanByte key, ref SpanByte value, RecordMetadata recordMetadata, long numberOfRecords)
         {
+            if (!firstRead)
+            {
+                logger?.LogTrace("First Read {key} {value}", key.ToString(), value.ToString());
+                firstRead = true;
+            }
             var needToFlush = false;
             while (true)
             {
@@ -162,6 +169,8 @@ public void OnStop(bool completed, long numberOfRecords, bool isMainStore, long
 
             logger?.LogTrace("{OnStop} {store} {numberOfRecords} {targetVersion}",
                 nameof(OnStop), isMainStore ? "MAIN STORE" : "OBJECT STORE", numberOfRecords, targetVersion);
+
+            firstRead = false;
         }
     }
 

diff --git a/test/Garnet.test.cluster/ReplicationTests/ClusterReplicationDisklessSyncTests.cs b/test/Garnet.test.cluster/ReplicationTests/ClusterReplicationDisklessSyncTests.cs
@@ -31,7 +31,7 @@ public class ClusterReplicationDisklessSyncTests
         int testTimeout = (int)TimeSpan.FromSeconds(120).TotalSeconds;
 
         public Dictionary<string, LogLevel> monitorTests = new(){
-            { "ClusterDisklessSyncFailover", LogLevel.Error }
+            { "ClusterDisklessSyncFailover", LogLevel.Trace }
         };
 
         [SetUp]