Mention GODEBUG=fips140 in FIPS docs #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
Jan 21, 2025
gdams
approved these changes
Jan 22, 2025
dagood
requested changes
Jan 22, 2025
dagood
reviewed
Jan 30, 2025
Co-authored-by: Davis Goodin <[email protected]>
dagood
approved these changes
Feb 3, 2025
Co-authored-by: Davis Goodin <[email protected]>
|
I filed a couple followup issues, also gathered my thoughts on the topics: 🙂 |
qmuntal
added a commit
that referenced
this pull request
Feb 7, 2025
* mention GODEBUG=fips140 in FIPS docs * promote note to warning * Apply suggestions from code review Co-authored-by: Davis Goodin <[email protected]> * document that GOFIPS=1 no longer updates the configured FIPS mode * reintroduce GOFIPS * reintroduce GOFIPS * Apply suggestions from code review Co-authored-by: Davis Goodin <[email protected]> * mention GOFIPS * reword build options * reword macos * Apply suggestions from code review Co-authored-by: Davis Goodin <[email protected]> * add suggestion --------- Co-authored-by: Davis Goodin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1445.