-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XAML textures sampling support #41
Open
marekkedzierski
wants to merge
40
commits into
microsoft:master
Choose a base branch
from
marekkedzierski:xaml_textures_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,640
−5,906
Open
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
665845b
Basic support for XAML textures (tiled and linear mode); New formats …
5a664af
Fixed color swapping in shader. Removed unecessary code
a88fd65
Alpha mode support added
0a47b41
Create CubeTestUwp SwapChain format in BGRA.
jordanrh1 2df3797
Fixed CheckDirectFlipSupport to validate formats.
jordanrh1 1799bd2
Added checks to SetVidPnSourceAddress for mode change.
jordanrh1 439d0dd
Remove Sleep() from CubeTest and SDKLayers from Dolphin
jordanrh1 4ee6b9d
Include changes left out of SetVidPnSourceAddress commit.
jordanrh1 2224790
Link to CppCoreGuidlines from readme.md
jordanrh1 8ae16b3
Trace virtual address of render target for debugging.
jordanrh1 97dac10
Merge branch 'master' of https://github.com/Microsoft/graphics-driver…
jordanrh1 89eb884
Adding IotShell.exe to enable RS1 images.
jordanrh1 ce3591e
Merge pull request #42 from jordanrh1/master
jordanrh1 95e56d9
XAML Bringup - Implement DdiSetPredication for the NULL pointer case …
IoTDan ab0b7ad
XAML Bringup - skeleton DdiResourceCopyRegion11_1
IoTDan 25ea07a
Remove Firmware folder from Firmware.zip.
jordanrh1 f3d8558
Added required reg keys to INF.
jordanrh1 0bad4ea
Merge pull request #44 from jordanrh1/install_fix
jordanrh1 4554d18
Ensure highest warning level in UMD.
jordanrh1 d2957b0
Enable precompiled headers in rosumd.
jordanrh1 c62ac9f
Merge pull request #45 from jordanrh1/install_fix
jordanrh1 a1aec78
Enable WPP logging in RosUmd
jordanrh1 58ba82f
Merge pull request #46 from jordanrh1/install_fix
jordanrh1 1b1d231
Remove legacy projects/files
hideyukn88 78a4752
XAML texture samling support - fixes after review
marekkedzierski 59485d5
Create XAML tests in TAEF.
jordanrh1 82d4fd6
Remove excessive debugger output from RosUmdDeviceDdi.
jordanrh1 5f8ad72
Add tracing to resource creation and opening.
jordanrh1 debdf4e
Moved XamlTests to RosTest.
jordanrh1 c06fdd3
Merge pull request #47 from jordanrh1/xaml_tests
jordanrh1 d2cf51b
Fixes after second review
ffdffdf
Fixing some issues with IoT shell extension.
hideyukn88 d2ce05e
Add comments for Issue 37
hideyukn88 490889c
Basic support for XAML textures (tiled and linear mode); New formats …
f557aee
Fixed color swapping in shader. Removed unecessary code
412180c
Alpha mode support added
7b79ad3
XAML texture samling support - fixes after review
marekkedzierski 084a8e0
Fixes after second review
e33d7e2
Fix after merge
marekkedzierski 2a528b1
Now <memory> is included in precompiled header
marekkedzierski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Alpha mode support added
commit 412180c1384d2aebe019341921c1463a228737ac
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -363,6 +363,13 @@ void MapDxgiFormatToInternalFormats(DXGI_FORMAT format, UINT &bpp, RosHwFormat & | |
} | ||
break; | ||
|
||
case DXGI_FORMAT_A8_UNORM: | ||
{ | ||
bpp = 32; | ||
rosFormat = RosHwFormat::X8888; | ||
} | ||
break; | ||
|
||
default: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the desired behavior for all other formats, or catch-all for 'not-implemented' formats? If not implemented, please add assertions or throw exception. |
||
bpp = 8; | ||
rosFormat = RosHwFormat::X8; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider:
boolean bSwapColorChannel = (texFormat == DXGI_FORMAT_B8G8R8A8_UNORM);