Skip to content

Commit

Permalink
Switch from yarn to npm
Browse files Browse the repository at this point in the history
  • Loading branch information
rzhao271 committed Feb 3, 2025
1 parent a4b088e commit 84ebec3
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions .azure-pipelines/publish-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ extends:
- script: npm ci
displayName: Install NPM dependencies

- script: yarn ts-node ./scripts/ci/monaco-editor-core-prepare nightly
- script: npm run ts-node ./scripts/ci/monaco-editor-core-prepare nightly
env:
VSCODE_REF: ${{ parameters.vscodeRef }}
PRERELEASE_VERSION: ${{ parameters.prereleaseVersion }}
Expand All @@ -78,7 +78,7 @@ extends:
- script: npm ci
displayName: Install NPM dependencies

- script: yarn ts-node ./scripts/ci/monaco-editor-prepare nightly
- script: npm run ts-node ./scripts/ci/monaco-editor-prepare nightly
env:
VSCODE_REF: ${{ parameters.vscodeRef }}
PRERELEASE_VERSION: ${{ parameters.prereleaseVersion }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ jobs:

- name: Install website node modules
working-directory: website
run: yarn install --frozen-lockfile
run: npm ci

- name: Build website
working-directory: website
run: yarn run build
run: npm run build

- name: Test website
working-directory: website
run: yarn test
run: npm run test
2 changes: 1 addition & 1 deletion .github/workflows/website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
uses: actions/checkout@v3
- uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 # pin@v2
with:
node-version: 16
node-version: 20
- name: Cache node modules
id: cacheNodeModules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ This can be done directly from the VS Code repository and does not involve the m

- Clone the [VS Code repository](https://github.com/microsoft/vscode): `git clone https://github.com/microsoft/vscode`
- Open the repository in VS Code: `code vscode`
- Run `yarn install`
- Run `npm install`
- Select and run the launch configuration "Monaco Editor Playground" (this might take a while, as it compiles the sources):

![](./docs/launch%20config.png)
Expand Down
28 changes: 14 additions & 14 deletions scripts/ci/monaco-editor-core.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ set -e

# cwd must be the vscode repository.

yarn --frozen-lockfile --network-timeout 180000
yarn playwright-install
yarn gulp hygiene
yarn valid-layers-check
yarn --cwd build compile
yarn eslint
yarn monaco-compile-check
yarn --max_old_space_size=4095 compile
npm ci
npm run playwright-install
npm run gulp hygiene
npm run valid-layers-check
cd build && npm run compile && cd -
npm run eslint
npm run monaco-compile-check
npm run compile

yarn test-browser --browser chromium
npm run test-browser --browser chromium

yarn gulp editor-distro
npm run gulp editor-distro
mkdir typings-test

cd typings-test
Expand All @@ -25,10 +25,10 @@ echo "import '../out-monaco-editor-core';" > a.ts
cd ..

cd test/monaco
yarn run esm-check
yarn run bundle-webpack
yarn run compile
yarn test
npm run esm-check
npm run bundle-webpack
npm run compile
npm test
cd ../..

# npm package is now in dependencies/vscode/out-monaco-editor-core, ready to be published

0 comments on commit 84ebec3

Please sign in to comment.