Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines setInterval/setTimeout on faked globalThis in unit test #4664

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

hediet
Copy link
Member

@hediet hediet commented Aug 29, 2024

No description provided.

@hediet hediet enabled auto-merge August 29, 2024 15:45
@hediet hediet disabled auto-merge August 29, 2024 15:45
@hediet hediet enabled auto-merge (rebase) August 29, 2024 15:45
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 29, 2024
joyceerhl
joyceerhl previously approved these changes Aug 29, 2024
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this debt that should go in for September? The less changes after testing the better

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2024

Oh actually this is monaco editor so I don't think it impacts vscode's endgame 👌

@Tyriar Tyriar modified the milestones: August 2024, September 2024 Sep 3, 2024
@aiday-mar
Copy link
Contributor

We decided to undo the package upgrade change here and just push the code change first.
Then we will publish a new monaco-editor-core package with the fix for the webpack smoke test
Then we will bump the version of the package on main on monaco-editor

@hediet hediet merged commit 3c7eb57 into main Sep 18, 2024
4 checks passed
@hediet hediet deleted the hediet/b/zesty-snail branch September 18, 2024 12:45
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants