Add Error Checking for Prompt Length vs. Max Length #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natke
previously requested changes
Jan 16, 2025
aciddelgado
force-pushed
the
aciddelgado/max_length
branch
from
372005e to
2f58d58
Compare
baijumeswani
approved these changes
Jan 21, 2025
natke
reviewed
Jan 21, 2025
baijumeswani
pushed a commit
that referenced
this pull request
Jan 31, 2025
This adds an error check for when the prompt length + current sequence length exceeds the user-defined max length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an error check for when the prompt length + current sequence length exceeds the user-defined max length.