Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mobile/examples/object_detection/android/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
This is a basic Object Detection sample application for [ONNX Runtime](https://github.com/microsoft/onnxruntime) on Android with [Ort-Extensions](https://github.com/microsoft/onnxruntime-extensions) support for pre/post processing. The demo app accomplishes the task of detecting objects from a given image.

The model used here is from source: [Yolov8 in extensions](https://github.com/microsoft/onnxruntime-extensions/blob/64f20828ce0291394886e277c23529cd1d11320d/tutorials/yolo_e2e.py#L37) and with pre/post processing support.
The default output model with onnxruntime-extension tools wouldn't include 'scaled_box_out_next' which is used in this example for displaying class-lable and confidence. One more step is required to get that.
Copy link
Contributor

@edgchen1 edgchen1 Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default output model with onnxruntime-extension tools wouldn't include 'scaled_box_out_next' which is used in this example for displaying class-lable and confidence. One more step is required to get that.
The default output model with onnxruntime-extension tools doesn't include 'scaled_box_out_next' which is used in this example for displaying class label and confidence. One more step is required to get that.

Please Add a `Debug()` on top of [`onnxruntime-extensions/onnxruntime_extensions/tools/add_pre_post_processing_to_model.py:270`](https://github.com/microsoft/onnxruntime-extensions/blob/981cb049ff956a1c99ab178b36ffc83664a678f2/onnxruntime_extensions/tools/add_pre_post_processing_to_model.py#L270).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe show a diff to make the code change clear? this link points to a comment and the required change is not obvious to me. still good to have a link to the code though.


This model (Yolov8n) can be fed with image bytes directly and outputs the detected objects with bounding boxes.

Expand Down Expand Up @@ -38,4 +40,4 @@ Clone this repository to get the sample application. Then open the project under
Here are some sample example screenshots of the app.

<img width=20% src="images/Screenshot_1.png" alt="App Screenshot 1" />
<img width=20% src="images/Screenshot_2.png" alt="App Screenshot 2" />
<img width=20% src="images/Screenshot_2.png" alt="App Screenshot 2" />
Loading