-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add failOnStatusCode option to API request context #34346
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
… Include flag for BrowserContext
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@yury-s made changes based on your comments whenever you have time to take a look. Unsure about the changes for protocol.yml file since some of the checks are failing due to that. But I believe it was necessary to generate the correct channels.d.ts and validator.ts files |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"15 failed 0 passed Merge workflow run. |
Add failOnStatusCode option to API request context so that the flag is applied to every request made unless specified.
References issue #34204