Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add failOnStatusCode option to API request context #34346

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

JacksonLei123
Copy link

Add failOnStatusCode option to API request context so that the flag is applied to every request made unless specified.

References issue #34204

This comment has been minimized.

docs/src/api/params.md Outdated Show resolved Hide resolved
tests/library/global-fetch.spec.ts Outdated Show resolved Hide resolved
tests/library/global-fetch.spec.ts Outdated Show resolved Hide resolved
packages/playwright-core/types/types.d.ts Outdated Show resolved Hide resolved
docs/src/api/params.md Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JacksonLei123 JacksonLei123 requested a review from yury-s January 20, 2025 17:44
@JacksonLei123
Copy link
Author

@yury-s made changes based on your comments whenever you have time to take a look. Unsure about the changes for protocol.yml file since some of the checks are failing due to that. But I believe it was necessary to generate the correct channels.d.ts and validator.ts files

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

15 failed
❌ [chromium] › tests/components/codeMirrorWrapper.spec.tsx:71:5 › highlight JavaScript @web-components-web
❌ [chromium] › tests/components/codeMirrorWrapper.spec.tsx:76:5 › highlight Python @web-components-web
❌ [chromium] › tests/components/codeMirrorWrapper.spec.tsx:81:5 › highlight Java @web-components-web
❌ [chromium] › tests/components/codeMirrorWrapper.spec.tsx:86:5 › highlight C# @web-components-web
❌ [chromium] › tests/components/codeMirrorWrapper.spec.tsx:91:5 › highlight lines @web-components-web
❌ [chromium] › tests/components/expandable.spec.tsx:22:5 › should render collapsed @web-components-web
❌ [chromium] › tests/components/expandable.spec.tsx:29:5 › should render expanded @web-components-web
❌ [chromium] › tests/components/expandable.spec.tsx:36:5 › click should expand @web-components-web
❌ [chromium] › tests/components/splitView.spec.tsx:22:5 › should render @web-components-web
❌ [chromium] › tests/components/splitView.spec.tsx:35:5 › should render sidebar first @web-components-web
❌ [chromium] › tests/components/splitView.spec.tsx:49:5 › should render horizontal split @web-components-web
❌ [chromium] › tests/components/splitView.spec.tsx:64:5 › should hide sidebar @web-components-web
❌ [chromium] › tests/components/splitView.spec.tsx:77:5 › drag resize @web-components-web
❌ [chromium] › tests/shared/imageDiffView.spec.tsx:37:5 › should render links @web-components-web
❌ [chromium] › tests/shared/imageDiffView.spec.tsx:46:5 › should show diff by default @web-components-web

0 passed
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants