-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: truncated filters on network tab #34395
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"7 flaky37596 passed, 648 skipped Merge workflow run. |
Hey @agg23 could you take a look please? |
Scrollable toolbar isn't a great UX. I'd suggest overflow drop down style or expandable filter that takes entire row. |
Thank you for the PR. I agree with Pavel; we probably want a dropdown here just like what happens to the |
Yeah, I don't disagree with @pavelfeldman's point. Will update shortly and reach out. Thanks both |
hey @pavelfeldman @agg23 would you guys be happy with this arrangement? |
I would make the dropdown styled the same as the tabbed one above (left justify, at least). Also make it as small as possible to still render all of the filter labels without overflow. Finally, we ideally want to switch to this dropdown form only once the parent block size decreases past a certain point. |
hey @pavelfeldman @agg23 could you take a peek please? Once you're both happy I can clean things up and resubmit the changes. Screen.Recording.2025-01-25.at.18.36.05.mov |
I think that is suitable for now. |
We discussed internally and we think it would be better if we had a proper overflow menu. As items move off of the screen, they should be added to a dropdown. Otherwise the options stay as top level buttons. |
fixes: #33930
Before:
![image](https://private-user-images.githubusercontent.com/1655210/404662395-07558363-ad50-4148-a0a8-5801da5d07af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mjg5MDMsIm5iZiI6MTczODkyODYwMywicGF0aCI6Ii8xNjU1MjEwLzQwNDY2MjM5NS0wNzU1ODM2My1hZDUwLTQxNDgtYTBhOC01ODAxZGE1ZDA3YWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMTE0MzIzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTRmMjBlZDRlZjYwMDI1YjM2ODJkMjYxZDg4ZjNiNThiNGQ0ZmM1M2VhYWI0MjIwMDI4NzFiOWVmYTc3MmRkNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.jyd-RMsDFRxBU4bYcwj7Mr9S_0LQWkMQCCWVAmXuXo8)
After:
![image](https://private-user-images.githubusercontent.com/1655210/404662269-e7f04004-76a5-456d-a46a-a4c22f5516a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mjg5MDMsIm5iZiI6MTczODkyODYwMywicGF0aCI6Ii8xNjU1MjEwLzQwNDY2MjI2OS1lN2YwNDAwNC03NmE1LTQ1NmQtYTQ2YS1hNGMyMmY1NTE2YTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMTE0MzIzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2U1NGVmMjBhNjYyMDRiZWFlMzNjNzVkYjQ5YTc0Mzg1ZjIwYTdlMjFkMmRlMzUzZmM1M2ExNjFiYmY4Y2VmOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.zQa38zvpJDDL6PCF2hziiG6IrLy0rwv5UH9hc34aE-U)