Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Windows browser process close test #34469

Closed
wants to merge 3 commits into from
Closed

chore: fix Windows browser process close test #34469

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e462d98
Enable logging of Windows taskkill command
agg23 Jan 24, 2025
ee7b0e6
Forward stdio and cause test failure
agg23 Jan 27, 2025
7ae7048
Log stdout directly
agg23 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/library/signals.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test('should close the browser when the node process closes', async ({ startRemo
const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE });
try {
if (isWindows)
execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`, { stdio: 'ignore' });
console.log(execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`, { stdio: 'inherit' }));
else
process.kill(remoteServer.child().pid);
} catch (error) {
Expand All @@ -40,6 +40,7 @@ test('should close the browser when the node process closes', async ({ startRemo
// We might not get browser exitCode in time when killing the parent node process,
// so we don't check it here.
expect(await remoteServer.childExitCode()).toBe(isWindows ? 1 : 0);
expect(false).toBe(true);
});

test('should remove temp dir on process.exit', async ({ startRemoteServer, server, platform }, testInfo) => {
Expand Down
Loading