-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): websocket client when running in Bun #34546
Open
DonIsaac
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
DonIsaac:don/fix/bun-ws
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"24 flaky37713 passed, 654 skipped Merge workflow run. |
I'd suggest that we wait for Bun to support connection upgrade instead, what is this blocking? |
This is blocking users connecting to already-running chromium browsers when running playwright on Bun. Bun has no plans to support upgrading in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Does
Fixes a problem where
chromium.connectOverCDP
fails to connect when running Playwright in Bun. Related issue: oven-sh/bun#9911The Problem
Bun's HTTP client does not currently support upgrading connections to other protocols, which breaks breaks
ws
(and other manual websocket implementations). To keep packages using it from breaking, Bun interceptsws
imports and provides a polyfill that wraps a WATWGWebSocket
.This normally works fine, but Playwright bundles
ws
at build time, so the import is never made. This PR updatesutilsBundle.ts
to detect if Playwright is running in Bun and, if so, use Bun's built-inws
module.Notes
Notably, this PR does not shim ws'
WebSocketServer
,Recevier
, orSender
classes.node:http
, so anything built on top ofnode:net
should be fine.