feat(svelte): add support for svelte5

[shfx]

Adding support for svelte5.

This change works for us but I need some additional eyes and hands to verify if this is what you might need to upgrade to svelte5. Keep in mind this PR is using somewhat legacy api that is there just to help migration and should be rewritten to "native" before they ditch it (somewhere around svelte6)

Closes #30278

[shfx]

@microsoft-github-policy-service agree

[agg23]

There's a lot of diff here because of auto-formatting. Please remove these changes.

[mxschmitt]

I think we actually want to introduce ct-svelte4-vite to keep testing for vite4, wdyt @agg23

[agg23]

Agreed

[shfx]

Sure, I'll will try to do that today. Thanks for the input.

[agg23]

No rush, but you still have a bunch of formatting changes and stuff that doesn't pass the linter.

[shfx]

Ugh, some issues after a rebase. I will fix those issues tomorrow, both linting and npm issue as I don't have much time after my 9-5 job.

I also don't think I can fully make it backward compatible as there is no option to attach slots to svelte4 components like there was in the previous version of the library.

[shfx]

I think bumping vite to 6.1.0 in the project root broke my pipelines.

[shfx]

Will try to rebase tomorrow if there is a fix for that.

[shfx]

I don't think I can fix the pipeline without someone bumping dependencies for react

❯ npm i        
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @vitejs/[email protected]
npm error Found: [email protected]
npm error node_modules/vite
npm error   dev vite@"^6.1.0" from the root project
npm error   peer vite@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" from @vitejs/[email protected]
npm error   node_modules/@vitejs/plugin-basic-ssl
npm error     dev @vitejs/plugin-basic-ssl@"^1.2.0" from the root project
npm error   4 more (@sveltejs/vite-plugin-svelte, ...)
npm error
npm error Could not resolve dependency:
npm error peer vite@"^4.2.0 || ^5.0.0" from @vitejs/[email protected]
npm error node_modules/@vitejs/plugin-react
npm error   dev @vitejs/plugin-react@"^4.2.1" from the root project
npm error   @vitejs/plugin-react@"^4.2.1" from @playwright/[email protected]
npm error   packages/playwright-ct-react
npm error     @playwright/[email protected]
npm error     node_modules/@playwright/experimental-ct-react
npm error       workspace packages/playwright-ct-react from the root project
npm error   1 more (@playwright/experimental-ct-react17)
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/vite
npm error   peer vite@"^4.2.0 || ^5.0.0" from @vitejs/[email protected]
npm error   node_modules/@vitejs/plugin-react
npm error     dev @vitejs/plugin-react@"^4.2.1" from the root project
npm error     @vitejs/plugin-react@"^4.2.1" from @playwright/[email protected]
npm error     packages/playwright-ct-react
npm error       @playwright/[email protected]
npm error       node_modules/@playwright/experimental-ct-react
npm error         workspace packages/playwright-ct-react from the root project
npm error     1 more (@playwright/experimental-ct-react17)
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error

[agg23]

I think you should be able to update @vitejs/plugin-react without issue.

[shfx]

I can, was not sure if I should do it in this PR. Gonna try it today.

[github-actions]

Test results for "tests 1"

1 failed
❌ [playwright-test] › tests/reporter-html.spec.ts:2737:5 › merged › execSync doesnt produce a second stdout attachment @macos-latest-node18-2

2834 passed, 13 skipped
✔️✔️✔️

Merge workflow run.