Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Features for Robo HAT MM1 board #1075

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Conversation

wallarug
Copy link
Contributor

Ready to push first iteration of Robo HAT MM1 board.

The Robo HAT MM1 is developed and maintained by the Robotics Masters team. Information about the board can be found on Crowd Supply.

https://www.crowdsupply.com/robotics-masters/robo-hat-mm1

Must be Merged at same time as PR 290 in the microsoft/pxt-maker repository

@wallarug
Copy link
Contributor Author

@peterpanstechland can also verify working.

Copy link
Member

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove gch file

@wallarug
Copy link
Contributor Author

Remove gch file

completed! @pelikhan

@pelikhan
Copy link
Member

We need to test these changes with a meow bit

@wallarug
Copy link
Contributor Author

Sure. Is that something you can do @pelikhan ?

Why that board specifically?

@pelikhan
Copy link
Member

Well we need to test a board with that MPU. I don’t have a computer so this will have to wait till next week.

@wallarug
Copy link
Contributor Author

wallarug commented Feb 16, 2020

@pelikhan ,

Is it just the MPU testing that is holding up this being merged in?

I know the MPU stuff has some issues (we tested) because the MPU on the Robo HAT is currently not included in the codal-core and due to issue 112 over on the codal-core repo. If that is the case - we can just switch that off / remove acceleratometer features for now until we get approval to update the codal-core.

Shake block does not work - because of the way the MPU6050 is being configured.

None of the changes (as far as I am aware) in this merge impact on other boards or functions of the library.

@pelikhan
Copy link
Member

Best to split PRs in smaller chunks.... and it’s holiday here in US so nothing going on before Tuesday.

@wallarug
Copy link
Contributor Author

Ok, no worries. I'll check back in on Wednesday. Thanks for the update.

#define CFG_PIN_RCC2 1018
#define CFG_PIN_RCC3 1019
#define CFG_PIN_RCC4 1020
#define CFG_PIN_SERVO1 1021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For parity with pins allocate keys for servo 0 through 32

@pelikhan pelikhan merged commit 1c9350c into microsoft:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants