Fix infinite loop in isThirdPartyPyTypedPresent logic of _getModuleNameForImport
#6233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Oct 25, 2023
erictraut
approved these changes
Oct 25, 2023
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6232
getRootLengthwasn't handling URIs withoutauthority(single slash after colon) correctly. In the case ofuntitled:/(length 10) it was returning 11 under the assumption that there were two trailing slashes. This causedisDiskPathRootto incorrectly returnfalse. IfisDiskPathRootreturnstrueinstead,_tryWalkUpwill returnfalsethus causing the_shouldWalkUploop to exit.