add dockerfile #1817
Open
add dockerfile #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for triage
you-n-g
reviewed
Jun 27, 2024
Dockerfile
Outdated
|
|
||
| RUN pip install cython packaging tables matplotlib statsmodels | ||
|
|
||
| RUN python setup.py install |
There was a problem hiding this comment.
I think cloning latest code is nightly.
We should distinguish stable version and nightly verion.
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Add this in the README or docs.
github-actions
bot
added
the
documentation
you-n-g
reviewed
Jun 28, 2024
| @@ -272,6 +272,25 @@ We recommend users to prepare their own data if they have a high-quality dataset | |||
| ``` | |||
| --> | |||
|
|
|||
| ## Build docker images | |||
There was a problem hiding this comment.
On the home page. Users care more about usage of docker image instead of creating it.
you-n-g
reviewed
Jun 28, 2024
|
|
||
| RUN python -m pip install cython packaging tables matplotlib statsmodels | ||
|
|
||
| RUN python -m pip install pyqlib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes