-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: .Net: ADR for realtime #10355
base: main
Are you sure you want to change the base?
Conversation
37648e7
to
c83fedd
Compare
9d56798
to
d416016
Compare
d416016
to
ace06eb
Compare
ace06eb
to
7560b88
Compare
afa206e
to
30e4b81
Compare
|
||
It might also be possible that a single event from the service contains multiple content items, for instance a response might contain both text and audio, in that case multiple events will be emitted. It might also be that a single service event is represented twice, i.e. once as a AudioEvent and once as a ServiceEvent, this once again gives the most flexibility to the developer. | ||
|
||
```python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some observations.
- Should we instead of having specialized Image/Audio events, have ContentEvent with the specific content within it?
I'm asking that because in M.E.AI we dropped the Image and Audio specialization in favor of Data
for any binary information.
- I would suggest that all events should be
ServiceEvent
specializations. Following also @westey-m point, I would suggest having theinner_event
|raw_representation
for the baseServiceEvent
where this would be the way to get the event name, not fully sure of exposing the underlying service event name as part of the abstraction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the logic in this, however these events are going both ways, you also create them to send data to the service and not all of those have content, some are empty, but you just call with the right service event type, so that isn't always the way to get the event name!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and only having a content event and then not having a different internal type for image or audio (as they are both data), means that you would have to dig into the actual event or match on the event type, that seems like a worse experience
5c3938f
to
deba679
Compare
Motivation and Context
ADR describing the preliminary design for realtime API's.
As these API's themselves are in preview, we might have to deal with incompatible changes down the road.
Description
Contribution Checklist