-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: improved content inits, added ndarray support for binary content and small fixes to defaults #10469
Merged
eavanvalkenburg
merged 5 commits into
microsoft:main
from
eavanvalkenburg:fix_binary_content_init
Feb 12, 2025
Merged
Python: improved content inits, added ndarray support for binary content and small fixes to defaults #10469
eavanvalkenburg
merged 5 commits into
microsoft:main
from
eavanvalkenburg:fix_binary_content_init
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67e9e65
to
4da0e7f
Compare
Python Test Coverage Report •
Python Unit Test Overview
|
moonbox3
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to update the PR title to be more descriptive, instead of simply "bunch of updates for content..." :)
79fde50
to
a30dce8
Compare
moonbox3
approved these changes
Feb 12, 2025
alliscode
approved these changes
Feb 12, 2025
a30dce8
to
11ae25a
Compare
TaoChenOSU
approved these changes
Feb 12, 2025
alliscode
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds support for ndarray's as the content carrier for all binary content types (binary, image, audio) as that is more optimized for larger content.
It also does some fixes to the initialization of those content types and the underlying data uri type.
Also some fixes for unspecified default param in pydantic Field, language servers do not recognize
Field("default value")
as having a default, so changed those occurances toField(default="default value")
Description
Contribution Checklist