ConPTY: Fix shutdown if killed during startup #18588
Open
+105
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conpty
carlos-zamora
approved these changes
Feb 20, 2025
| if (_state != State::Starting) | ||
| { | ||
| // Here's where we _could_ call CloseConsoleProcessState(), but this function | ||
| // only gets get called once when the first client connects and CONSOLE_INITIALIZED |
There was a problem hiding this comment.
Suggested change
| // only gets get called once when the first client connects and CONSOLE_INITIALIZED | |
| // only gets called once when the first client connects and CONSOLE_INITIALIZED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During startup we relinquish ownership of the console lock to wait for the DA1 response of the hosting terminal. The problem occurs if the hosting terminal disconnects during that time. The broken pipe will cause
VtIoto send outCTRL_CLOSE_EVENTmessages, but those won't achieve anything, because the first and only client hasn't even finished connecting yet. What we need to do instead is to return an error code.In order to not use a bunch of booleans to control this behavior, I gave
VtIoa state enum. This however required restructuring the calling code in order to not have a dozen states.Validation Steps Performed