Skip to content

Commit

Permalink
speed up binskim (#6205)
Browse files Browse the repository at this point in the history
With the current pattern, binskim takes 3-5min everytime it runs which
is on every artifact we produce, which basically close to double the
build time...

Maybe one day ms tooling will learn to use an efficient glob library
  • Loading branch information
timotheeguerin authored Feb 28, 2025
1 parent 3fe2d61 commit 2f19d4e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eng/tsp-core/pipelines/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ extends:
template: /eng/common/pipelines/templates/1es-redirect.yml
parameters:
BinSkimSettings:
analyzeTargetGlob: +:file|**/dist/*.exe;-:f|**/tsp.exe # Flag issue with node binary which we can't fix https://github.com/nodejs/node/issues/42100
analyzeTargetGlob: +:file|*.exe;-:f|**/tsp.exe # Flag issue with node binary which we can't fix https://github.com/nodejs/node/issues/42100
variables:
- template: /eng/tsp-core/pipelines/templates/variables/globals.yml@self

Expand Down

0 comments on commit 2f19d4e

Please sign in to comment.