code snippet provider #13018
Open
code snippet provider #13018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
reviewed
Dec 5, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
|
|
||
| export async function registerCopilotContextProvider(): Promise<void> { | ||
| try { | ||
| const isCustomSnippetProviderApiEnabled = await telemetry.isExperimentEnabled("CppToolsCustomSnippetsApi"); |
There was a problem hiding this comment.
We can't do audience filtering and set this flag at the same time. Instead, on the Copilot side you'll need to modify the construction of activeExperiments in CompletionContext to check for the experiment, then update the resolver here to respect activeExperiments.
Alternatively, if the intent of this check was to act as a kill-switch then you can leave it as-is (although we'll still need the activeExperiments plumbing). We'll just need to be sure that CppToolsCustomSnippetsApi is at 100% rollout for all VS Code traffic before starting the actual experiment.
sean-mcmanus
requested changes
Dec 6, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
sean-mcmanus
reviewed
Dec 6, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
|
@lukka Soon you should be able to take a dependency on https://www.npmjs.com/package/@github/copilot-language-server to get appropriate typings. The types aren't quite there yet, but https://github.com/github/copilot-client/pull/6250 is adding them. |
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
2 times, most recently
from
991df60 to
22235f3
Compare
lukka
commented
Dec 7, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
lukka
commented
Dec 7, 2024
sean-mcmanus
previously requested changes
Dec 9, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
sean-mcmanus
reviewed
Dec 9, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
sean-mcmanus
reviewed
Dec 9, 2024
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
22235f3 to
0679bab
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
0679bab to
b996200
Compare
This is done, thanks! |
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
2 times, most recently
from
a7f8949 to
d1876a2
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
4 times, most recently
from
2919dcb to
391433a
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
391433a to
9ee7b88
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
9ee7b88 to
0c8d03d
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
0c8d03d to
5b63116
Compare
sean-mcmanus
requested changes
Jan 22, 2025
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
5b63116 to
40780f2
Compare
sean-mcmanus
previously approved these changes
Jan 24, 2025
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
2 times, most recently
from
dc61198 to
21f7254
Compare
sean-mcmanus
previously approved these changes
Jan 28, 2025
Colengms
reviewed
Jan 28, 2025
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
21f7254 to
3f89017
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
3f89017 to
02ec023
Compare
sean-mcmanus
approved these changes
Jan 29, 2025
Colengms
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.