Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces code-no-deep-import-of-internal #245143

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Conversation

hediet
Copy link
Member

@hediet hediet commented Mar 31, 2025

This ESLint rule makes sure only siblings of "internal" source code folders can import into it (so they can either use it directly or re-export public API).

This (usually) means that an import like this is not allowed:

import { autorunWithStore, debouncedObservable, derived } from '../../../../base/common/observableInternal/base.js';

...whereas this import is allowed:

import { autorunWithStore, debouncedObservable, derived } from './observableInternal/base.js';

@hediet hediet self-assigned this Mar 31, 2025
@hediet hediet enabled auto-merge (rebase) March 31, 2025 16:26
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Mar 31, 2025
@hediet hediet disabled auto-merge March 31, 2025 17:08
@hediet hediet enabled auto-merge (squash) March 31, 2025 17:09
@hediet hediet force-pushed the hediet/b/nutty-pinniped branch from b37529f to 0baa64b Compare March 31, 2025 17:48
@hediet hediet closed this Apr 1, 2025
auto-merge was automatically disabled April 1, 2025 08:05

Pull request was closed

@hediet hediet reopened this Apr 1, 2025
@hediet hediet merged commit 13cf8e4 into main Apr 1, 2025
12 checks passed
@hediet hediet deleted the hediet/b/nutty-pinniped branch April 1, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants