Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version: ZugferdCommunity.QubaViewer version 1.4.0 #190815

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update version: ZugferdCommunity.QubaViewer version 1.4.0 #190815

wants to merge 2 commits into from
+11 −7

Conversation

damn-good-b0t
Copy link
Contributor

@damn-good-b0t damn-good-b0t commented Nov 12, 2024 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with komac v2.6.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@damn-good-b0t damn-good-b0t mentioned this pull request Nov 12, 2024
Merged
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 12, 2024
stephengillie
stephengillie requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the DisplayVersion has so many downsides, using it when unnecessary is an anti-pattern.

manifests/z/ZugferdCommunity/QubaViewer/1.4.0/ZugferdCommunity.QubaViewer.installer.yaml Outdated Show resolved Hide resolved
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Nov 13, 2024
auto-merge was automatically disabled November 13, 2024 10:54

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Changes-Requested Changes Requested labels Nov 13, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 13, 2024
@stephengillie
Copy link
Collaborator

Hi @damn-good-b0t,

This manifest removes the DisplayVersion from the AppsAndFeaturesEntries, which is present in previous manifest versions. This entry should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 897.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 13, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damn-good-b0t @wingetbot @stephengillie @ItzLevvie