Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(consul): consul's implementation was refactored (#3109) #3163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(consul): consul's implementation was refactored (#3109) #3163

wants to merge 2 commits into from

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Aug 13, 2023 •
edited
Loading

relatd: #3109

@flyingcrp
refactor(consul): consul's implementation was refactored (#3109)
90b3de3 
* refactor(consul): consul's implementation was refactored

* test(del): Delete some unused files

* test(comment): Merge test cases
@czy88840616 czy88840616 added pr: new feature This PR adds a new API or behavior. pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. labels Aug 13, 2023
@czy88840616 czy88840616 added this to the 3.12.x milestone Aug 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 91.53% and project coverage change: -0.06% ⚠️

Comparison is base (8714c96) 84.22% compared to head (90b3de3) 84.16%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3163      +/-   ##
==========================================
- Coverage   84.22%   84.16%   -0.06%     
==========================================
  Files         470      468       -2     
  Lines       44210    44154      -56     
  Branches     5328     5325       -3     
==========================================
- Hits        37235    37162      -73     
- Misses       6937     6954      +17     
  Partials       38       38
Files Changed Coverage Δ
packages/consul/src/consul.service.ts 86.07% <86.07%> (ø)
packages/consul/src/config/config.default.ts 100.00% <100.00%> (ø)
packages/consul/src/configuration.ts 100.00% <100.00%> (+3.00%) ⬆️
packages/consul/src/controller/consul.ts 100.00% <100.00%> (ø)
packages/consul/src/index.ts 100.00% <100.00%> (ø)
packages/consul/src/interface.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616
Copy link
Member Author

这个 PR 改动有点大。。先 holding，等我抽象出服务发现的接口再继续。

@czy88840616 czy88840616 added the status: Holding Same features may be hold, and implements layer. label Aug 14, 2023
@czy88840616 czy88840616 removed this from the 3.12.x milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: new feature This PR adds a new API or behavior. status: Holding Same features may be hold, and implements layer.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czy88840616 @codecov-commenter @flyingcrp