Update OpenFeature to 1.14.0 #5347
Open
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Jan 23, 2025
| // Track implements openfeature.IClient. | ||
| func (_ *FakeClient) Track(_ context.Context, _ string, _ openfeature.EvaluationContext, _ openfeature.TrackingEventDetails) { | ||
| panic("unimplemented") | ||
| } |
There was a problem hiding this comment.
Any way we could mock this instead?
There was a problem hiding this comment.
Actually, it occurred to me that we could define a narrower slice of the interface (we basically need IClient.Boolean), but I'd prefer to do that as a separate refactor. I could do that before this merge if you'd prefer.
JAORMX
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #5339
@rado correctly pointed out that
openfeature.IClientintroduced new methods that we needed to implement in our fake.Change Type
Mark the type of change your PR introduces:
Testing
Unit tests
Review Checklist: