De not set XFS retry_timeout_seconds as max_retries is zero (#980)

if max_retries is 0, then there's no point in setting retry_timeout_seconds Co-authored-by: Bala FA <[email protected]>
minio · Dec 2, 2024 · e7ddffe · e7ddffe
1 parent ddec617
commit e7ddffe
Showing 1 changed file with 0 additions and 12 deletions.
diff --git a/pkg/xfs/mount_linux.go b/pkg/xfs/mount_linux.go
@@ -46,26 +46,14 @@ func mount(device, target string) error {
 		klog.ErrorS(err, "unable to set EIO max_retries device", "name", name)
 	}
 
-	if err := os.WriteFile("/sys/fs/xfs/"+name+"/error/metadata/EIO/retry_timeout_seconds", []byte("5"), 0o644); err != nil {
-		klog.ErrorS(err, "unable to set EIO retry_timeout_seconds for device", "name", name)
-	}
-
 	if err := os.WriteFile("/sys/fs/xfs/"+name+"/error/metadata/ENOSPC/max_retries", []byte("0"), 0o644); err != nil {
 		klog.ErrorS(err, "unable to set ENOSPC max_retries device", "name", name)
 	}
 
-	if err := os.WriteFile("/sys/fs/xfs/"+name+"/error/metadata/ENOSPC/retry_timeout_seconds", []byte("5"), 0o644); err != nil {
-		klog.ErrorS(err, "unable to set ENOSPC retry_timeout_seconds for device", "name", name)
-	}
-
 	if err := os.WriteFile("/sys/fs/xfs/"+name+"/error/metadata/default/max_retries", []byte("0"), 0o644); err != nil {
 		klog.ErrorS(err, "unable to set default max_retries device", "name", name)
 	}
 
-	if err := os.WriteFile("/sys/fs/xfs/"+name+"/error/metadata/default/retry_timeout_seconds", []byte("5"), 0o644); err != nil {
-		klog.ErrorS(err, "unable to set default retry_timeout_seconds for device", "name", name)
-	}
-
 	return nil
 }