Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose vault logging #502

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Verbose vault logging #502

wants to merge 7 commits into from

Conversation

ramondeklein
Copy link
Contributor

This PR adds the following functionality:

  • Always log Vault authentication failures.
  • Enable verbose Vault HTTP logging by setting .keystore.vault.verbose to true (default is disabled).

@ramondeklein ramondeklein self-assigned this Jan 13, 2025
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch 3 times, most recently from 92eac4f to 7b779b6 Compare January 13, 2025 15:43
ramondeklein
ramondeklein commented Jan 13, 2025
View reviewed changes
cmd/kes/server.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ramondeklein ramondeklein requested a review from aead January 13, 2025 16:42
@ramondeklein ramondeklein marked this pull request as ready for review January 13, 2025 16:42
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch 3 times, most recently from 0cffa26 to 8295cbf Compare January 13, 2025 16:53
aead
aead requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@aead aead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, without the additional config field

kesconf/file.go Outdated Show resolved Hide resolved
kesconf/config.go Outdated Show resolved Hide resolved
@aead aead force-pushed the verbose-vault-logging branch from 8295cbf to 2c90351 Compare January 30, 2025 09:29
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch from 2c90351 to efb88c5 Compare February 3, 2025 11:19
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch from b673e09 to 9e44368 Compare February 3, 2025 11:45
@ramondeklein
Copy link
Contributor Author

I processed the review comments. I find it kind of nasty to use slog.Default(), but the logger (or log-level) isn't available from the actual Store implementation.

@ramondeklein ramondeklein requested a review from aead February 3, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aead aead Awaiting requested review from aead

Requested changes must be addressed to merge this pull request.

Assignees

@ramondeklein ramondeklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramondeklein @aead