-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for listening to global events #1110
Conversation
Please run |
Co-authored-by: minio-trusted <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebozduman Can you also check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add tests to Minio.Functional.Tests
for the new notifications as we run the functional tests for PRs.
It looks like |
Please rerun the regitlint check and check the functional test failure, |
@ebozduman @ramondeklein I'm encountering an issue with the |
@adelinag08 The latest version of the tooling seems to be more strict. We need to address this to ensure the checks are working again. I have submitted PR #1124 to address this. |
Please disregard the following comment.
|
* adds missing parts of the fix in PR #1110 * increases subscription wait time * moves wait to its proper place * lint changes * incorporates review comment * lint changes * unreported regitlint changes --------- Co-authored-by: Ersan Bozduman <[email protected]>
This reverts commit 93007be. # Conflicts: # Minio/Minio.csproj
This reverts commit a2589e1. # Conflicts: # Minio.Examples/Cases/ListenNotifications.cs
This PR implements the following:
ListenNotificationsAsync
that usesListenBucketNotificationsAsync
to listen for global notifications without a bucket name setResolves #1109