allow users to extend DNS style buckets #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to allow for custom extensions, since we keep getting new requests to add new URLs as default for bucket DNS style requests. This is not scalable for this SDK, allowing a caller specific function allows callers can write their own function and provide us when they wish to use path style or bucket DNS style.
This was referenced Jan 27, 2025
|
PTAL @klauspost |
klauspost
approved these changes
Feb 2, 2025
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this pull request
Feb 10, 2025
…itea#6875) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) | require | patch | `v7.0.84` -> `v7.0.85` | --- ### Release Notes <details> <summary>minio/minio-go (github.com/minio/minio-go/v7)</summary> ### [`v7.0.85`](https://github.com/minio/minio-go/releases/tag/v7.0.85): Bugfix Release [Compare Source](minio/minio-go@v7.0.84...v7.0.85) #### What's Changed - Update s3-endpoints.go with ISO endpoints by [@&go-gitea#8203;vnzongzna](https://github.com/vnzongzna) in minio/minio-go#2053 - Implement error interface for RemoveObjectError by [@&go-gitea#8203;wuhaochen](https://github.com/wuhaochen) in minio/minio-go#2058 - allow users to extend DNS style buckets by [@&go-gitea#8203;harshavardhana](https://github.com/harshavardhana) in minio/minio-go#2057 #### New Contributors - [@&go-gitea#8203;vnzongzna](https://github.com/vnzongzna) made their first contribution in minio/minio-go#2053 - [@&go-gitea#8203;wuhaochen](https://github.com/wuhaochen) made their first contribution in minio/minio-go#2058 **Full Changelog**: minio/minio-go@v7.0.84...v7.0.85 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNTguMiIsInVwZGF0ZWRJblZlciI6IjM5LjE1OC4yIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6875 Reviewed-by: Gusted <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to allow for custom extensions, since
we keep getting new requests to add new URLs
as default for bucket DNS style requests. This
is not scalable for this SDK, allowing a caller
specific function allows callers can write their
own function and provide us when they wish to use
path style or bucket DNS style.