fix: don't error for missing baseConfig, when makeServer is provided #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have created a PR #2215 that in addition to addressing this concern, will also allow what was the makeServer function to actually be a default exported function. This should help with the embroider issues. If you agree, I would close this PR in favor of that one. Sorry for the churn, if I only knew then when I know now :) |
|
Thanks so much! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts a fix for #2212.
The bug arises when an app defines an
export function makeServer(), but doesn't also define anexport default function ().According to the Mirage docs, this use case is supported. In practice, it is not.
https://github.com/miragejs/ember-cli-mirage/blob/f0ce745cfbe8f10a0b7ae7b2c32aa1c46e0e63e0/tests/dummy/app/pods/docs/advanced/server-configuration/template.md
The change in this PR was made naively, editing the specific conditional causing the error to be thrown, without a full understanding of code being changed. Nonetheless, this fixed my own issues and the Mirage development server ran without issue.