Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Merge sync-pageBuilderTemplate branch #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vidurb
Copy link

@vidurb vidurb commented May 1, 2019

Contains the addition of the pageBuilder template.

@vidurb vidurb requested a review from rungta May 1, 2019 08:39
Copy link
Member

@rungta rungta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing _routers/component.twig.

@vidurb
Copy link
Author

vidurb commented May 1, 2019

Added in next commit.

@vidurb vidurb requested a review from rungta May 1, 2019 10:11
{% include '_routers/component.twig' with {
entry: entry,
params: component|merge({
type: component.type()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire merge appears redundant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if you look at it out of context that is the consequence. As I remember, without the addition of that merge, the component router doesn't function correctly. Whether the 'fix' should be moved from the page builder to the component router, I don't know.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it now and wait for the error to crop up again in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the error? Can you try reproducing it on a live project?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the error was that the component router checks for type.handle and throws an error because type is lazy-loaded.

Copy link
Author

@vidurb vidurb May 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment removed pending redaction

@vidurb vidurb requested a review from rungta May 1, 2019 12:44
@vidurb
Copy link
Author

vidurb commented May 3, 2019

Twig Runtime Error – Twig\Error\RuntimeError Key "type" for array with keys "fieldId, ownerId, ownerSiteId, typeId, sortOrder, collapsed, deletedWithOwner, id, tempId, uid, fieldLayoutId, contentId, enabled, archived, siteId, enabledForSite, title, slug, uri, dateCreated, dateUpdated, trashed, resaving, duplicateOf, hasDescendants, ref, status, structureId, totalDescendants, url, kind, label, caption, class" does not exist.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants