-
Notifications
You must be signed in to change notification settings - Fork 0
Merge sync-pageBuilderTemplate branch #27
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing _routers/component.twig
.
Added in next commit. |
{% include '_routers/component.twig' with { | ||
entry: entry, | ||
params: component|merge({ | ||
type: component.type() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire merge
appears redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if you look at it out of context that is the consequence. As I remember, without the addition of that merge, the component router doesn't function correctly. Whether the 'fix' should be moved from the page builder to the component router, I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove it now and wait for the error to crop up again in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the error? Can you try reproducing it on a live project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC the error was that the component router checks for type.handle
and throws an error because type
is lazy-loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment removed pending redaction
|
Contains the addition of the pageBuilder template.