Exclude xmlsec version 1.3.14 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blarghmatey
reviewed
Jul 8, 2024
renovate-config.json
Outdated
| }, | ||
| { | ||
| "matchPackageNames": ["xmlsec"], | ||
| "allowedVersions": "<=1.3.13" |
There was a problem hiding this comment.
Since it looks like the problem is specifically with 1.3.14 I would argue that rather than setting the specifer to <=1.3.13 it should just be !/1\.3\.14/ so that we can continue to get updates for newer releases, but avoid this specific problematic version.
There was a problem hiding this comment.
pt2302
changed the title
blarghmatey
reviewed
Jul 8, 2024
blarghmatey
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Related to xmlsec/python-xmlsec#314. This has notably caused problems in
ocw-studio, requiring multiple manual reverts (e.g., mitodl/ocw-studio#2180, mitodl/ocw-studio#2235).Description (What does it do?)
This PR excludes the
xmlsecversion 1.3.14 across allmitodlrepositories for Renovate.How can this be tested?
This can be tested by running
renovate --dry-runin a relevant repository (such asocw-studio) and verifying that thexmlsecversion is not upgraded to 1.3.14.