Improved performances for assignment listing #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified "staff_grading_data" function to be able to pull infos for many students or a specific one - Fixed bug with multiple identical incremental ajax requests: - Now the cancel button of the "Enter Grade" modal does not trigger an Ajax get request
| assignments = data.get('assignments') | ||
| self.assertIsNotNone(assignments) | ||
| self.assertEqual(len(assignments), 2) | ||
| # 50b287502d8dbf83bec2dcfb78fc4d8e |
There was a problem hiding this comment.
I left that behind: it's the anonymous student ID for that test
pdpinch
added a commit
that referenced
this pull request
Sep 4, 2015
Improved performances for assignment listing fixes #111 [delivers #101927046]
|
Oy. I forgot I need to run tests by hand, and they're not passing... |
|
Yes, I suggest to revert this merge and reopen the PR: we need to figure out if they fail also on master (like it looked to me) or only after my changes. |
|
Right, right. You told me about that. I forgot. I'll revert it. |
|
If you restore the branch, I'll remove that useless comment @noisecapella found |
|
branch is restored. And I have a PR with the revert. |
This was referenced Nov 16, 2016
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many students or a specific one
Ajax get request