Add support for Django 4.2 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@irtazaakram Sorry, It took us so long to get back to you on this PR. Could you rebase? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 53.75% 53.75%
=======================================
Files 16 16
Lines 1680 1680
Branches 115 115
=======================================
Hits 903 903
Misses 764 764
Partials 13 13 ☔ View full report in Codecov by Sentry. |
arslanashraf7
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Looks good 👍 Thanks for creating this PR @irtazaakram .
I still see a couple of warnings but they are not related to Django4 upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
edx/upgrades#365
What's this PR do?
Any background context you want to provide?
This is related to ongoing effort to upgrade openedx to Django 4.2
Please can we have a new release after this PR is merged.
Thanks,