[ChangeLog] Different image background #1624
Open
+55
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
junhouse
commented
Nov 14, 2024
•
junhouse
commented
- Image background gradient update
- Remove margin-top if no image exists above the heading
junhouse
requested review from
matthathornmp and
ishamehramixpanel
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryancurtis1
reviewed
Nov 14, 2024
| @@ -107,7 +107,7 @@ export default function ChangelogIndex({ more = "Learn More" }) { | |||
| <div className="changelogIndexItemBody"> | |||
| {page.frontMatter?.thumbnail && renderImage(page)} | |||
|
|
|||
| <h3 className="changelogItemTitleWrapper"> | |||
| <h3 className={page.frontMatter?.thumbnail && "changelogItemTitleWrapper"}> | |||
There was a problem hiding this comment.
It looks like this would completely remove the title if there is no image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.