Add dontUpdateUrl option to Router.navigate #155
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mduan
force-pushed
the
md-router-dont-update-url
branch
2 times, most recently
from
f989d8c
to
04cb569
Compare
mduan
force-pushed
the
md-router-dont-update-url
branch
from
04cb569
to
76a5eaa
Compare
mduan
commented
Jun 17, 2022
Comment on lines
+324
to
+332
| el.setAttribute(`style-override`, `:host { background-color: red; }`); | ||
| await nextAnimationFrame(); | ||
| expect(getComponentStylesheetText(el)).to.equal(`:host { color: blue; }:host { background: red; }`); | ||
| expect(getComponentStylesheetText(el)).to.equal(`:host { color: blue; }:host { background-color: red; }`); | ||
| }); | ||
|
|
||
| it(`it applies the styles even if the component isn't attached to the DOM`, function () { | ||
| el = document.createElement(`shadow-dom-app`); | ||
| el.setAttribute(`style-override`, `:host { background: red; }`); | ||
| expect(getComponentStylesheetText(el)).to.equal(`:host { color: blue; }:host { background: red; }`); | ||
| el.setAttribute(`style-override`, `:host { background-color: red; }`); | ||
| expect(getComponentStylesheetText(el)).to.equal(`:host { color: blue; }:host { background-color: red; }`); |
There was a problem hiding this comment.
Fix test failure in Firefox: expected ':host { color: blue; }:host { background: red none repeat scroll 0% 0%; }' to equal ':host { color: blue; }:host { background: red; }'
Unrelated to my changes (happens on master).
mduan
commented
Jun 17, 2022
| @@ -68,13 +68,15 @@ export default class Router { | |||
| this.window.history[this.historyMethod] = this.origChangeStateMethod; | |||
| } | |||
|
|
|||
| navigate(fragment, stateUpdate = {}) { | |||
| navigate(fragment, stateUpdate = {}, {dontUpdateUrl = false} = {}) { | |||
There was a problem hiding this comment.
I considered naming the flag updateUrl, but slightly prefer false by default param, so went with dontUpdateUrl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for https://github.com/mixpanel/analytics/pull/41714