Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default_config for Django versions 3.2+ #35

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

mschoettle
Copy link
Contributor

Addresses deprecation warning:

django.utils.deprecation.RemovedInDjango41Warning: 'slippers' defines default_app_config = 'slippers.apps.SlippersConfig'. Django now detects this configuration automatically. You can remove default_app_config.

See: https://docs.djangoproject.com/en/4.0/releases/3.2/#automatic-appconfig-discovery

Btw: Awesome package!

@mschoettle
Copy link
Contributor Author

@mixxorz Please review :)

mixxorz
mixxorz previously approved these changes Mar 4, 2023
Copy link
Owner

@mixxorz mixxorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you

@mixxorz mixxorz enabled auto-merge (squash) March 4, 2023 06:04
auto-merge was automatically disabled March 4, 2023 14:48

Head branch was pushed to by a user without write access

@mschoettle mschoettle requested a review from mixxorz March 4, 2023 14:51
@mschoettle
Copy link
Contributor Author

Thanks! The pipeline failure should be fixed now. Is there any chance that this can be released soon?

@zerolab
Copy link
Contributor

zerolab commented Jul 26, 2023

Considering anything belowe Django 3.2 is no longer supported, perhaps it is time to drop this entirely?

@mschoettle
Copy link
Contributor Author

@mixxorz Could this be merged and released with the next version?

@zerolab Agreed. Could be done in a subsequent PR.

@mixxorz mixxorz enabled auto-merge (squash) July 27, 2023 18:44
Copy link
Owner

@mixxorz mixxorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

@mixxorz mixxorz merged commit bdfe838 into mixxorz:main Jul 27, 2023
5 checks passed
@zerolab
Copy link
Contributor

zerolab commented Jul 28, 2023

#46 for dropping default_app_config (and Python 3.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants