-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lv2, serd, sord, sratom, and lilv support to macOS build. #15 #43
Conversation
cd $VERSION-$ARCH | ||
source $PROGDIR/environment.sh $ARCH | ||
|
||
./waf configure build --lv2dir "$MIXXX_PREFIX/Library/Audio/Plug-Ins/LV2" --prefix="$MIXXX_PREFIX" --no-plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't --lv2dir
be /Library/Audio/Plug-Ins/LV2
according to the LV2 standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anything need to be specified for the --lv2dir
argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't set --lvd2dir then this installer script tries to install a bunch of manifest junk to /Library/Audio/Plug-Ins/LV2 on the build VM, so I changed it to $PREFIX//Library/Audio/Plug-Ins/LV2. I don't know what we're supposed to do with these manifests -- does Mixxx need to install them on the user's computer? We don't have an installer on macOS, the user just drops the Mixxx.app bundle into /Applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put another way, we don't want to change the build VM's global state since each environment should be hermetic, so I had this write to $MIXXX_PREFIX/Library/Audio/Plug-Ins/LV2
instead of /Library/Audio/Plug-Ins/LV2
.
From what I can tell, this option only affects where files are written -- I grepped for $MIXXX_PREFIX
in all of the generated files and it doesn't occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I presumed --lv2dir
set the default plugin search path, but it seems I was wrong. It's not clear to me what these manifests do or if they're really necessary. The README in schemas.lv2 says "These are included with LV2 and installed as a bundle to support validation and
more intelligent use of data by hosts."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, well I'll merge this now. If there is an issue with macOS builds detecting LV2 plugins, let's keep this in mind.
CI build passed 👍 |
No description provided.