Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update korg_kaoss_dj.rst #430

Open
wants to merge 2 commits into
base: 2.3
Choose a base branch
from

Conversation

raphaelquast
Copy link

add new assignments for
mixxxdj/mixxx#4301

Comment on lines +51 to +53
| 10 | Touchpad (controller mode) | Controls the effects of the DJ software. The | Controls Quick-Effect super knobs |
| | | vertical axis controls the mix (dry/wet) knob | the horizontal-axis controls deck 1 |
| | | and the horizontal axis controls the super | the vertical-axis controls deck 2 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're touching this unrelated lines, please try to boil down the text
Controls the effects of the DJ software. The vertical axis controls the mix (dry/wet) knob and the horizontal axis controls the super knob.
to something like

Controls effect unit 1.
Y axis: Mix knob (dry/wet)
X axis: Super knob.

@@ -62,29 +62,30 @@ Mapping
+------------------------------------------------+------------------------------------------------+------------------------------------------------+------------------------------------------------+
| 12 | Touch Slider mode button | Switches between the three touch slider mode | |
+------------------------------------------------+------------------------------------------------+------------------------------------------------+------------------------------------------------+
| 13 | Touch Slider (Normal mode) | Left Side - Nudges (pitch -) | Moves to the specified position in the song |
| 13 | Touch Slider (Normal mode) | Left - Nudges (pitch -) | Moves to the specified position in the song |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the rows below:
I think some formatting or line breaks in columns 3+4 would improve readability a lot.
Current state looks like this:
image

The text can also be improved, for example

Set hotcue / go to set hotcue
Left: 1 / Center: 2 / Right: 3

and in a similiar way for the shifted mode description.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the text is in fact formatted with line-breaks like this:

| ... | ... | Left - Deletes Hot Cue 1  |
| ... | ... | Center - Deletes Hot Cue 2|
| ... | ... | Right- Deletes Hot Cue 3  |

It should be formatted in the doc (parsed via Sphinx i guess) as 3 individual lines.
However Github's preview interprets this as a Markdown table that does not support newlines which is why it looks like a mess in your screenshot 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not just a preview, it's the actual online manual.
for markdown we need better separators then to increase readability.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, well as far as I know this is supposed to be the correct way for specifying newlines in re-structured text...
I think what's happening here is that the lines exceed the max. number of characters and then auto-wrapping takes over and the newlines are no longer correctly parsed...

this would explain this: (from the online-doc)
(all entries are written with newlines but it only works as intended for "Deletes Hot Cue ."
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I understand that.
what I was proposing as "better separators" is simply something like Left: set hotcue... instead of Left - set hotcue...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, yep that seems reasonable!
I'll try to come up with a better readable version as soon as i find the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants