S4 MK3 internal mixer #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
reviewed
Apr 7, 2024
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
|
@ronso0 if you have a chance, could you please help me getting the dependent PR merged? That should ease the work on that one and prevent headachy conflicts :) |
acolombier
force-pushed
the
feat/s3-mk3-internal-mixer
branch
from
7038ec7
to
bd0f89a
Compare
|
LGTM, do you consider this finished? I just merged #634 , wanna rebase? |
acolombier
force-pushed
the
feat/s3-mk3-internal-mixer
branch
from
bd0f89a
to
ec8e1c3
Compare
|
All ready now! |
ronso0
reviewed
Apr 16, 2024
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Show resolved
Hide resolved
ronso0
reviewed
Apr 16, 2024
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Show resolved
Hide resolved
ronso0
requested changes
Apr 16, 2024
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: ronso0 <[email protected]>
ronso0
reviewed
Apr 23, 2024
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: ronso0 <[email protected]>
|
Thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #634
Manual update related to this change